Don't suggest private methods #682
Conversation
…hod and properties Checking the visibility and the context from where the node is: inside a method declaration or after an instantiation
Ignoting Netbeans conf
…into fix/visibility
|
Could you add a test for this? |
|
Yes, I can. Travis keeps failing because of the line ending. |
|
What editor are you using? You should configure it to trim trailing whitespace (or delete it manually) |
|
I use VS Code and Netbeans, I configured VS Code. |
Added CompletionWithVisibilityTest.php - checks visibility of a property or method call (only public) - checks visibility of a Class (can see all methods and properties) - checks visibility of a child class (public and protected)
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
===========================================
+ Coverage 82.17% 82.38% +0.2%
- Complexity 935 944 +9
===========================================
Files 44 44
Lines 2154 2168 +14
===========================================
+ Hits 1770 1786 +16
+ Misses 384 382 -2
|
Other tests were failing because I modifed the global_symbols.php file
|
Would you mind fixing merge conflicts? |
|
I did merge the branch already, sorry, I have to get used to the code. I removed the part of the static checking. I would like to test it better. |
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=========================================
Coverage 82.38% 82.38%
Complexity 944 944
=========================================
Files 44 44
Lines 2168 2168
=========================================
Hits 1786 1786
Misses 382 382 |
To avoid errors on Travis with line ending.
This branch has the same fix for showing private and protected methods and properties out of the context.
Fixes #469