Allow configurable file extension for indexing #308

JSteitz · 2017-02-18T00:50:08Z

Requires the PR from vscode-php-intellisense felixfbecker/vscode-php-intellisense#77

Will take the options sent by the client. Option: php.intellisense.fileTypes = [".php"]

codecov · 2017-02-18T00:54:41Z

Codecov Report

Merging #308 into master will increase coverage by 0.05%.
The diff coverage is 90%.

@@             Coverage Diff              @@
##             master     #308      +/-   ##
============================================
+ Coverage     86.23%   86.28%   +0.05%     
- Complexity      718      729      +11     
============================================
  Files            53       54       +1     
  Lines          1460     1480      +20     
============================================
+ Hits           1259     1277      +18     
- Misses          201      203       +2

Impacted Files	Coverage Δ	Complexity Δ
src/Options.php	`90% <90%> (ø)`	`11 <11> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbfd70d...f7175bc. Read the comment docs.

JSteitz · 2017-02-18T00:58:26Z

If everything is fine I will do the other 3 requests :)

src/Indexer.php

staabm · 2017-02-18T08:36:32Z

src/Indexer.php

+     * @param Index                  $sourceIndex
+     * @param PhpDocumentLoader      $documentLoader
+     * @param \stdClass|null         $composerLock
+     * @param IndexerOptions|null    $options


jens1o · 2017-02-18T09:46:01Z

src/Options.php

    {
        // Do nothing when the $options parameter is not an object
-        if (!is_object($options)) {
+        if (!is_object($options) && !is_array($options) && (!$options instanceof \Traversable)) {


that won't work, you need to do it like this: !($options instanceof \Traversable)

I'll add tests for the Option class when I'm back

@jens1o actually instanceof binds stronger than !, so it works and the parenthesis around it are not needed. But I usually do them for readability.

ah, thanks. Didn't knew that.

jens1o · 2017-02-18T09:49:01Z

src/Options.php

+        foreach ($options as $option => $value) {
+            $method = 'set' . ucfirst($option);
+
+            call_user_func([$this, $method], $value);


Check first wether the method exists?

thx will do it later when I'm back home again

I would rather not use setter methods at all and let Options have public attributes.

@felixfbecker How would you validate/filter the option? Calling them extra or using __set()?

I wouldn't. In the LS code I just don't assign invalid values and JSONMapper will throw if the @var tags don't match the type

Will it notify the client about the invalid value type?
What about arrays that could have any type as value? E.g. $fileTypes = ['.php', false]

Since the options are coming from the client we should validate/filter them

Sure, the exception can be caught and propagated to the client.
What do you mean arrays that can have any type as value? $fileTypes would be of type string[]

jens1o · 2017-02-18T09:53:02Z

src/Options.php

+    {
+        $fileTypes = filter_var_array($fileTypes, FILTER_SANITIZE_STRING);
+        $fileTypes =  filter_var($fileTypes, FILTER_CALLBACK, ['options' => [$this, 'filterFileTypes']]);
+        $fileTypes = array_filter($fileTypes);


You need to provide a callback for array_filter

With no callback it will remove all that are false, but I can add one

https://secure.php.net/manual/en/function.array-filter.php says, that the second parameter must be provided. But you could use strlen, that will filter any false, empty strings or null.

Weird for me it says it is optional :/

If no callback is supplied, all entries of array equal to FALSE (see converting to boolean) will be removed.

jens1o · 2017-02-18T09:56:17Z

src/Options.php

+    public function setFileTypes(array $fileTypes)
+    {
+        $fileTypes = filter_var_array($fileTypes, FILTER_SANITIZE_STRING);
+        $fileTypes =  filter_var($fileTypes, FILTER_CALLBACK, ['options' => [$this, 'filterFileTypes']]);


I think it may be possible that you'll pass false into this method. Also, you've inserted a double space

Yeah, did a manual test before I used it, will be tested later

felixfbecker · 2017-02-18T10:10:51Z

src/LanguageServer.php

     * @return Promise <InitializeResult>
     */
-    public function initialize(ClientCapabilities $capabilities, string $rootPath = null, int $processId = null): Promise
+    public function initialize(ClientCapabilities $capabilities, string $rootPath = null, int $processId = null, $initializationOptions = null): Promise


I didn't know vscode sends the settings as initializationOptions, I thought didChangeConfiguration was the only way. Is there a reason you didn't type $initializationOptions as a class (Options)?

Microsoft has a list with all methods and params: https://github.com/Microsoft/language-server-protocol/blob/master/versions/protocol-2-x.md#initialize

You only have to pass them from vscode as a property of ClientOptions

According to the Docs it can have any type.

I can't force every client to do this. This needs to happen through onDidChangeConfiguration.

The actual options are taken from the configuration and are just passed with the initialize method. felixfbecker/vscode-php-intellisense@59e6f2c

So you want to move the indexing to onDidChangeConfiguration? Otherwise you would index 2x, because this event is sent after the intialize (by vscode).

Tricky. A client might never send onDidChangeConfiguration. But it should definitely be retriggered if the config is sent through that.

I would open a new issue to discuss this part because it affects the indexing for many option combinations. And maybe delay it until we have implemented some of them.

For now it is okay, when the user has to reload to reindex with the changed options.
I have already some ideas but I need to collect more details for how the indexing will be affected.

I would want at least an implementation of onDidChangeConfiguration that, if this setting changed, wipes the index and reindexes, because I don't want to add an important feature like this to the language server if it only works in VS Code

But feel free to discuss in an issue

felixfbecker · 2017-02-18T10:12:24Z

src/Options.php

+            $method = 'set' . ucfirst($option);
+
+            call_user_func([$this, $method], $value);
+        }


I would rather let JsonMapper do this (like it does for all protocol structures) instead of doing this here

To sanitize the file type option, we provide a setter method for the property that will be called by the JsonMapper.

codecov-io · 2017-02-18T18:31:29Z

Codecov Report

Merging #308 into master will increase coverage by 0.34%.
The diff coverage is 96.42%.

@@             Coverage Diff             @@
##             master    #308      +/-   ##
===========================================
+ Coverage     84.15%   84.5%   +0.34%     
- Complexity      811     830      +19     
===========================================
  Files            59      60       +1     
  Lines          1717    1768      +51     
===========================================
+ Hits           1445    1494      +49     
- Misses          272     274       +2

Impacted Files	Coverage Δ	Complexity Δ
src/Options.php	`100% <100%> (ø)`	`5 <5> (?)`
src/LanguageServer.php	`92.85% <100%> (+0.08%)`	`20 <11> (ø)`	❌
src/Index/Index.php	`71.42% <100%> (+2.8%)`	`22 <1> (+1)`	✅
src/Index/AbstractAggregateIndex.php	`93.75% <100%> (+0.41%)`	`27 <2> (+2)`	✅
src/Indexer.php	`64% <100%> (+0.98%)`	`18 <0> (ø)`	❌
src/Server/Workspace.php	`80.35% <92.85%> (+11.39%)`	`41 <12> (+11)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8eccb...23a40f0. Read the comment docs.

haringsrob · 2017-02-27T10:48:33Z

This is a blocker for me, anything I can do here to speed it up? :)

JSteitz · 2017-02-27T10:54:27Z

Code for the didConfigurationChange is done, but the event is somehow not triggering for me.
Didn't have enough time this week to investigate.

…into feature/allow-configurable-file-extension-for-indexing

Currently only the default Options type and the vscode format are accepted.

…e indexer

JSteitz · 2017-03-04T12:08:24Z

src/Server/Workspace.php

    {
        if ($settings === null) {
            return;
        }

+        // VSC sends the settings with the config section as main key
+        if ($settings instanceof \stdClass && $settings->phpIntelliSense) {


Not happy with this part.
The documentation is lacking in which format the settings are passed to the server and why they do it that way.
With all the different tests I did, they always send it like that:

{ "ExtensionConfigSectionName": { // defined in the package.json in the vscode extensions ... the actual settings ... } }

felixfbecker · 2017-03-04T13:47:37Z

src/Server/Workspace.php

+        // VSC sends the settings with the config section as main key
+        if ($settings instanceof \stdClass && $settings->phpIntelliSense) {
+            $mapper = new \JsonMapper();
+            $settings = $mapper->map($settings->phpIntelliSense, new Options);


Can we just use php as the config section? "IntelliSense" is a term only associated with VS and VS Code.

Sure we can.

We only have to lookout for possible conflicts in the future when we use php as config section.

Possible config naming:

php.indexer.*

php.completion.* (possible name for a feature request, but can be ignored now)

php.intellisense.* (previous name)

php.fileExtensions should be fine. I don't think we should concern user with the concept of an "indexer"

felixfbecker · 2017-03-04T13:48:08Z

src/Server/Workspace.php

+            $settings = $mapper->map($settings->phpIntelliSense, new Options);
+        }
+
+        if (!($settings instanceof Options)) {


Afaik JsonMapper will throw when the schema doesn't match

Do you have to tell him to that?
Because for me JsonMapper never threw an exception when the schema didn't match.
It silently ignored invalid properties and used the defaults in the Options.

What case exactly did not throw an exception? It could be because you typed setFileTypes() as taking array, not string[]

felixfbecker · 2017-03-04T13:49:30Z

src/Server/Workspace.php

+        }
+
+        if (!($settings instanceof Options)) {
+            throw new \Exception('Settings format not valid.');


This should probably cause a window/showMessage since notifications do not return a response

felixfbecker · 2017-03-04T13:50:52Z

src/Options.php

+     *
+     * @param array $fileTypes List of file types
+     */
+    public function setFileTypes(array $fileTypes)


These functions are not needed if you let JsonMapper take care of validation

felixfbecker · 2017-03-04T14:55:27Z

src/Server/Workspace.php

+            $this->options->$prop = $val;
+        }
+
+        if ($this->indexer && !empty(array_intersect($changedOptions, $indexerOptions))) {


Can we for now just keep it simple and instead of getChangedOptions() just do

if ($this->options->fileTypes != $settings->php->fileTypes)

felixfbecker · 2017-03-04T14:58:49Z

tests/Server/Workspace/DidChangeConfigurationTest.php

+    {
+        $sourceIndex = new Index;
+        $dependenciesIndex = new DependenciesIndex;
+        $projectIndex = $this->getMockBuilder('LanguageServer\Index\ProjectIndex')


Is using ::class not possible?

Awesome you figured out mocking, this will be a much better pattern for asserting client interaction in the future than using event handlers on the protocol reader!

Ohh yeah my bad, forgot that we have ::class

felixfbecker · 2017-03-04T15:04:52Z

src/Server/Workspace.php

@@ -200,4 +214,75 @@ public function xdependencies(): array
        }
        return $dependencyReferences;
    }
+
+    /**
+     * Fires when client changes settings in the client


Change this to the protocol wording:

A notification sent from the client to the server to signal the change of configuration settings.

https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#didchangeconfiguration-notification

felixfbecker · 2017-03-04T15:06:33Z

src/Server/Workspace.php

+     * The default paramter type is Options but it also accepts different types
+     * which will be transformed on demand.
+     *
+     * Currently only the vscode format is supported


What does this mean? Where is the problem in saying the PHP LS reads settings under the php key?

felixfbecker · 2017-03-04T15:08:58Z

src/LanguageServer.php

@@ -190,6 +191,7 @@ public function initialize(ClientCapabilities $capabilities, string $rootPath =
            $this->projectIndex = new ProjectIndex($sourceIndex, $dependenciesIndex, $this->composerJson);
            $stubsIndex = StubsIndex::read();
            $this->globalIndex = new GlobalIndex($stubsIndex, $this->projectIndex);
+            $initializationOptions = $initializationOptions ?? new Options;


This way $initializationOptions is not an instance of Options if provided

Don't get you here, is this comment a part from another comment?

If $initializedOptions is not null, it will be stdClass because it's not typed. I also think you don't account for the nesting under ->php here

For $initializationOptions you have more freedom how and which options will be send.

The $initializationOptions parameter ist typed in initialize() and is only passed as is to coroutine(), so it should be enough only to check for null.

You pass this variable to the Indexer further down, which accepts Options, not stdClass

I'm really sorry but I don't see a problem here.
$initializationOptions is always of type Options.

At which point will it be a stdClass?

Oh sorry, I think I missed the type annotation because I looked at the closure use. But shouldn't this be the same object as passed to didChangeConfiguration? And will this break passing custom properties from the client in initializationOptions?

initializationOptions can be completely different to didChangeConfiguration.
And actually they are not the same in this PR. While initializationOptions returns only defined options in the extension, didChangeConfiguration will return the whole section with the section name as main key.

initializationOptions

{ "fileTypes": [ ".php" ] }

didChangeConfiguration

{ "php": { "executablePath": "\/usr\/local\/opt\/php71\/bin\/php", "fileTypes": [ ".php" ], "suggest": { "basic": true }, "validate": { "enable": true, "executablePath": "\/usr\/local\/opt\/php71\/bin\/php", "run": "onSave" } } }

It's up to us to defined - I am just saying it's a bit confusing that they are different. It would be much easier for a client if we just document please pass the didChangeConfiguration settings as initializationOptions

felixfbecker · 2017-03-04T15:11:06Z

src/Server/Workspace.php

+     * Currently only the vscode format is supported
+     *
+     * @param mixed|null $settings
+     * @return bool


what is the return value for? A notification does not return anything

I know and I was hesitating to add the return value, but for some tests I need them.
When you have another idea how I can test them, tell me.

see for example testNoOptionPassed or testNoChangedOptions

You shouldn't add return values just to do assertions when what you really want to test is that certain side effects happen. You should mock classes and then assert that a method is called or not.

haringsrob · 2017-03-08T17:38:18Z

src/Options.php

+    public function setFileTypes(array $fileTypes)
+    {
+        $fileTypes = filter_var_array($fileTypes, FILTER_SANITIZE_STRING);
+        $fileTypes =  filter_var($fileTypes, FILTER_CALLBACK, ['options' => [$this, 'filterFileTypes']]); // validate file type format


There is one space to much here.

jens1o · 2017-04-09T20:29:37Z

any news on this?

haringsrob · 2017-05-29T14:05:17Z

I dont think this will be done before #357 is done, and then it might be obsolete/require to be redone

martinfojtik · 2018-04-01T13:47:56Z

is somebody working on this?

JSteitz · 2018-04-11T13:32:49Z

Currently no.

Need to find some time to review and update to upstream.

…figurable-file-extension-for-indexing

* merge latest upstream * remove currently not required code blocks * fix tests

JSteitz · 2018-08-29T19:44:02Z

After revisiting this PR I removed all code blocks that are not needed.
Options are currently only relevant on startup and not "on the go",
meaning we need to restart vscode, when changes affect indexing.

My plans for now are:

Options that affect indexing require restart of vscode/languageserver
Show notification for required restart

codecov · 2018-08-29T19:48:54Z

Codecov Report

Merging #308 into master will decrease coverage by 10.65%.
The diff coverage is 30.47%.

@@              Coverage Diff              @@
##             master     #308       +/-   ##
=============================================
- Coverage     81.52%   70.86%   -10.66%     
- Complexity      912      941       +29     
=============================================
  Files            62       63        +1     
  Lines          2078     2169       +91     
=============================================
- Hits           1694     1537      -157     
- Misses          384      632      +248

Impacted Files	Coverage Δ	Complexity Δ
src/Client/Workspace.php	`21.42% <0%> (-78.58%)`	`4 <1> (+1)`
src/Index/AbstractAggregateIndex.php	`87.75% <0%> (-5.73%)`	`28 <2> (+2)`
src/Index/Index.php	`63.79% <0%> (-6.02%)`	`23 <1> (+1)`
src/Index/ProjectIndex.php	`91.66% <100%> (ø)`	`4 <1> (ø)`	⬇️
src/Options.php	`100% <100%> (ø)`	`5 <5> (?)`
src/Indexer.php	`13% <13.63%> (-45.23%)`	`24 <5> (+6)`
src/LanguageServer.php	`64.61% <41.93%> (-13.57%)`	`32 <5> (+5)`
src/Server/Workspace.php	`11.68% <7.69%> (-26.78%)`	`32 <10> (+9)`
src/Protocol/Hover.php	`0% <0%> (-100%)`	`1% <0%> (ø)`
src/ContentRetriever/ClientContentRetriever.php	`0% <0%> (-100%)`	`3% <0%> (ø)`
... and 16 more

The indexer is moved to the method initialized, so we can request configurations from the client to init the indexer itself.

JSteitz · 2018-08-31T12:49:35Z

@felixfbecker I have difficulties with race conditions. Any hints how I can make the workspace/configuration request before the didChangeConfiguration message is processed?.

Expected order:

initialize
initialized
didChangeConfiguration

What actually happens:

initialize
initialized (until requesting settings)
didChangeConfiguration (workspace not initialized at this point)
initialized (rest)

felixfbecker · 2018-08-31T12:56:29Z

Without fully understanding what's causing problems for you, you can save a Promise that you fulfill explicitely when initialization is done and yield in the coroutine that needs to wait for it. You can also emit it as an event on an EventEmitter and use a util like waitForEvent to get a Promise for it.

JSteitz · 2018-08-31T16:11:53Z

Looks like I have a general problem with initialized and the usage of workspace/configuration. (e317e8c#diff-b7156ac1be31f214d6450d4dbfa3d15fR293)

After investigating vscode-languageclient, I could see that the client is sending the reponse to my request after workspace/didChangeConfiguration, textDocument/didOpen and textDocument/documentSymbol are sent (last two when a php file is open at startup).
So it's not racing problem, my request is just queued after the initial requests :/

Both workspace and textDocument are not initialized at that point.
workspace requires a dependecny to indexer to allow reindexing on didChangeConfiguratioin.

Do we drop this part and only implement didChangeConfiguration?
initializationOptions is still available :)

* Handle the case where didChangeConfiguration is called before workspace/configuration request is resolved. * Implement basic cancellation signal request * Use defaults options and only apply new on request

JSteitz · 2018-08-31T18:57:41Z

Current state:

~~Options that affect indexing require restart of vscode/languageserver~~
Log notification for cancel request
Log notification for reindexing
Reindex when affected settings change
🏃 Handle cancel request in indexer
Start indexer after initialization
Request settings if capability is supported
Tests
Documentation

The cancel request for reindexing is working, but I'm not so happy with that.
For now you will get indexing messages (e.g. "Indexing project for definitions and static references"), but it will not run them.
Also the final message "X files are indexed in ..." is also wrong.

I was thinking to wrap the index in a try catch and throw an exception to abort indexing altogether,
but I don't think this is the right approach.

felixfbecker · 2018-08-31T18:59:11Z

src/Client/Workspace.php

+     * the result for the first configuration item in the params).
+     *
+     * @param ConfigurationItem[] $items
+     * @return Promise


What's the type of the Promise?

felixfbecker · 2018-08-31T18:59:34Z

src/Client/Workspace.php

+        return $this->handler->request(
+            'workspace/configuration',
+            ['items' => $items]
+        );


Shouldn't this be mapped to a class?

felixfbecker · 2018-08-31T19:08:41Z

src/Indexer.php

+
+            while ($this->isIndexing()) {
+                yield timeout();
+            }


I'm not that happy with this "polling" solution - usually cancellation is synchronous and best-effort. I.e. the old indexing would stop eventually but you can already start with the next index run, by just making sure to instantiate new Index objects (maybe even a new Indexer) so that the old run can't accidentally still write to the new index. Does that sound feasible?

Don't think a new Indexer instance is a good idea, they are used in 2 different places (initialized and didChangeConfiguration) and I would need a reference to both.

And I think creating new Index objects is too much work from what I see.
Are you talking about sourceIndex and dependencyIndex?

If yes, then the method would need to know about all objects that require the index objects. Or am I wrong here?

felixfbecker · 2018-08-31T19:09:59Z

src/Protocol/ConfigurationItem.php

+
+namespace LanguageServer\Protocol;
+
+class ConfigurationItem


A constructor would be good to reduce boilerplate

felixfbecker · 2018-08-31T19:11:46Z

src/LanguageServer.php

+                $configurationitem = new ConfigurationItem();
+                $configurationitem->section = 'php';
+                $configuration = yield $this->client->workspace->configuration([$configurationitem]);
+                $options = $this->mapper->map($configuration[0], new Options());


Shouldn't this be done by the configuration method?

As long as we don't say, we will only use settings from the section "php", i would not do that, because I know that people will ask for including files.exclude setting (see #159 (comment)).

felixfbecker · 2018-08-31T19:13:08Z

src/LanguageServer.php

+            // the workspace/didChangeConfiguration can be invoked before
+            // the response from the workspace/configuration request is resolved
+            if ($this->indexer->isIndexing()) {
+                return;


And why do you need to return in that case?

#308 (comment)

Because when the settings are different from default, the didChangeConfiguration is initiating the indexer. When it is already running, we know the running indexer is using the latest settings.

felixfbecker · 2018-08-31T19:14:13Z

src/LanguageServer.php

+                $this->indexer->setOptions($options);
+            }
+
+            $this->indexer->index()->otherwise('\\LanguageServer\\crash');


You should yield this instead and make the whole coroutine crash on error since notifications can't return error responses

Jürgen Steitz added 2 commits February 18, 2017 01:38

Add support to index multiple file extensions

cdb5b56

Will take the options sent by the client. Option: php.intellisense.fileTypes = [".php"]

Add test for indexing multiple file types

5f096c4

JSteitz mentioned this pull request Feb 18, 2017

WIP: support intellisense options in vscode felixfbecker/vscode-php-intellisense#77

Open

4 tasks

jens1o reviewed Feb 18, 2017

View reviewed changes

src/Indexer.php Show resolved Hide resolved

staabm reviewed Feb 18, 2017

View reviewed changes

Jürgen Steitz added 2 commits February 18, 2017 09:37

Fix wrong phpDoc type

7dc4477

Filter invalid file types and use default list as fallback

f7175bc

jens1o reviewed Feb 18, 2017

View reviewed changes

felixfbecker requested changes Feb 18, 2017

View reviewed changes

Jürgen Steitz added 2 commits February 18, 2017 19:30

Let JsonMapper intialize the options

9433694

To sanitize the file type option, we provide a setter method for the property that will be called by the JsonMapper.

Add test for fileTypes option

39cfbda

Jürgen Steitz added 5 commits February 18, 2017 20:05

Initialize options with default values when not provided by client

3c33e7f

Update testIndexingMultipleFileTypes

d2e5048

Add missing namespace in OptionsTest

b9d0d1b

Fix wrong classname for options test

9067b44

Wipe index when on configuration change

1e319c7

mousetraps mentioned this pull request Mar 1, 2017

Enable fileEvents in client options felixfbecker/vscode-php-intellisense#83

Merged

Jürgen Steitz added 5 commits March 2, 2017 23:11

Add list of valid indexer options

58c82e6

Implement didChangeConfiguration event

44a942e

Pass options and indexer to workspace

940eb97

Add tests

5b1b6bf

Merge branch 'master' of github.com:felixfbecker/php-language-server …

707c97f

…into feature/allow-configurable-file-extension-for-indexing

Jürgen Steitz added 5 commits March 4, 2017 12:30

Remove emitting wipe events

ca225ff

Accept different types/formats from clients

c4568bf

Currently only the default Options type and the vscode format are accepted.

Add new tests and update old ones

5308e7a

Fix phpcs warnings/errors

a06057b

Let didChangeConfiguration decide what options are interesting for th…

23a40f0

…e indexer

JSteitz commented Mar 4, 2017

View reviewed changes

felixfbecker requested changes Mar 4, 2017

View reviewed changes

Change didChangeConfiguration doc to protocol wording

f4f1067

haringsrob reviewed Mar 8, 2017

View reviewed changes

JSteitz added 3 commits August 29, 2018 21:21

Merge remote-tracking branch 'upstream/master' into feature/allow-con…

9cc2736

…figurable-file-extension-for-indexing

Refactor pull request

09fbec2

* merge latest upstream * remove currently not required code blocks * fix tests

Fix risky test warning

a5417cd

JSteitz mentioned this pull request Aug 29, 2018

Feature: configure file size limit #668

Open

JSteitz added 2 commits August 31, 2018 11:54

Start indexing after initialization

e317e8c

The indexer is moved to the method initialized, so we can request configurations from the client to init the indexer itself.

WIP: Implement didChangeConfiguration with reindexing

a1c3845

WIP: Implement didChangeConfiguration with reindexing

a1e5654

* Handle the case where didChangeConfiguration is called before workspace/configuration request is resolved. * Implement basic cancellation signal request * Use defaults options and only apply new on request

felixfbecker reviewed Aug 31, 2018

View reviewed changes

Partial work on feedback

a81bed9

felixfbecker changed the title ~~allow configurable file extension for indexing~~ Allow configurable file extension for indexing Nov 11, 2018

felixfbecker added the work needed label Nov 11, 2018

Allow configurable file extension for indexing #308

Are you sure you want to change the base?

Allow configurable file extension for indexing #308

Conversation

JSteitz commented Feb 18, 2017 • edited

codecov bot commented Feb 18, 2017 • edited

Codecov Report

JSteitz commented Feb 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JSteitz Feb 18, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JSteitz Feb 18, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jens1o Feb 18, 2017 • edited

Choose a reason for hiding this comment

JSteitz Feb 18, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jens1o Feb 18, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JSteitz Feb 18, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Feb 18, 2017 • edited by codecov bot

Codecov Report

haringsrob commented Feb 27, 2017

JSteitz commented Feb 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jens1o commented Apr 9, 2017

haringsrob commented May 29, 2017

martinfojtik commented Apr 1, 2018

JSteitz commented Apr 11, 2018

JSteitz commented Aug 29, 2018

codecov bot commented Aug 29, 2018 • edited by ghost

Codecov Report

JSteitz commented Aug 31, 2018

JSteitz commented Feb 18, 2017 •

edited

codecov bot commented Feb 18, 2017 •

edited

JSteitz Feb 18, 2017 •

edited

JSteitz Feb 18, 2017 •

edited

jens1o Feb 18, 2017 •

edited

JSteitz Feb 18, 2017 •

edited

jens1o Feb 18, 2017 •

edited

JSteitz Feb 18, 2017 •

edited

codecov-io commented Feb 18, 2017 •

edited by codecov bot

codecov bot commented Aug 29, 2018 •

edited by ghost