refactor(flutter_todos): add close to TodosApi
#4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
added
example
felangel
commented
Apr 27, 2024
| @@ -19,7 +19,9 @@ class LocalStorageTodosApi extends TodosApi { | |||
|
|
|||
| final SharedPreferences _plugin; | |||
|
|
|||
| final _todoStreamController = BehaviorSubject<List<Todo>>.seeded(const []); | |||
| late final _todoStreamController = BehaviorSubject<List<Todo>>.seeded( | |||
There was a problem hiding this comment.
Making this late so that the BehaviorSubject is instantiated lazily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Even though the lifetime of the
TodosApiinstance is tied to the application in this case, it's still valuable to add acloseAPI to the interface since theTodosApishould expose a way to close the instance and free any allocated resources. (closes #4154)Type of Change