Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add trailing slash to introduction section links #4153

Merged
merged 1 commit into from
Apr 23, 2024
Merged

docs: add trailing slash to introduction section links #4153

merged 1 commit into from
Apr 23, 2024

Conversation

orischwartz
Copy link
Contributor

@orischwartz orischwartz commented Apr 23, 2024 •
edited

Status

READY/IN DEVELOPMENT/HOLD

Breaking Changes

NO

Description

All the links in the left menu on https://bloclibrary.dev are broken -- require a trailing slash.

image

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel
Copy link
Owner

@orischwartz the links seem to be working fine for me. We also have a link-check as part of the CI which is passing. Can you please elaborate on what you mean by "broken"?

@felangel felangel changed the title fix: add trailing slash so links work docs: add trailing slash to introduction section links Apr 23, 2024
felangel
felangel approved these changes Apr 23, 2024
View reviewed changes
Copy link
Owner

@felangel felangel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site as is works fine for me using Chrome and Safari on MacOS (the trailing slash is automatically added) but happy to accept this PR.

If the links truly don't work for you could you please provide more information such as what browser and operating system you're using? Thanks!

@felangel felangel added the documentation Documentation requested label Apr 23, 2024
@felangel felangel merged commit 14defcd into felangel:master Apr 23, 2024
9 checks passed
@orischwartz
Copy link
Contributor Author

Might have been cached on your browser, it's an HTTP 301 which is cacheable

$ curl https://bloclibrary.dev/flutter-bloc-concepts
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   162  100   162    0     0   1794      0 --:--:-- --:--:-- --:--:--  1820<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx</center>
</body>

It's fixed now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@orischwartz orischwartz

Labels
documentation Documentation requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orischwartz @felangel