Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature #236: export note to pdf added. #921

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

unic77
Copy link

@unic77 unic77 commented May 25, 2023

A new item in the drop down menu (as shown in the pictures). When pressed, it wil create a PDF file that wil be stored in the documents folder of the user.

Test note:
image

Drop down menu:
image

Stored location:
image

Preview pdf fille:
image

@federicoiosue
Copy link
Owner

federicoiosue commented May 26, 2023

Awesome job, perfectly implemented!

I wrote to the old PR so you may have not read it but

I moved back the develop branch to SDK 31 (same with Jdk and Gradle tools). My fault, I forgot to add this breaking changes on a feature branch.

So please rebase your current feature branch on the current remote develop, this should also fix the currently failing github actions. Then I'll go with the merge!

@unic77
Copy link
Author

unic77 commented May 26, 2023

i dont know how to rebase a git hub branch. do u maybe have some links with information

@federicoiosue
Copy link
Owner

federicoiosue commented May 26, 2023

I'd to the following on your Git client:

  • Hard reset on remote develop branch (this commit)
  • Cherry pick your own commits
  • Force push on your own remote branch

The PR will be automatically updated I think

@federicoiosue federicoiosue added this to To do in Omni Notes via automation May 26, 2023
@federicoiosue federicoiosue added this to the 6.3.0 milestone May 26, 2023
@federicoiosue
Copy link
Owner

Like this

Registrazione.schermo.2023-05-26.alle.10.11.35.mov

@unic77
Copy link
Author

unic77 commented May 26, 2023

I think i fixed it. Thank you for the help.

@federicoiosue
Copy link
Owner

I created an example PR: #922

Please focus on the modified files: only the relevant ones are managed within the PR, they're 7 files. Instead this one hascurrently 16 files, most of the ones inherited from the old develop branch, the one before my rebase.

I still didn't tested the modification actually, so I suppose that it manages also images, as a minimum requirement. Am I correct?

@unic77
Copy link
Author

unic77 commented May 27, 2023

Only the tekst is converted to the PDF file in this implementation. I would like to work further on this feature, if that is somthing that u are interested in. But at the moment my final exams in school are starting, so i wont be able to help. If its oke with u i would like to work on this feature further when my finalls are done.

also thank u for all the help.

@federicoiosue
Copy link
Owner

No worries there is no ETA for any modification here.

I'll keep this PR open to let you have the time to fix the versioning tree (by compressing it to be like the one in #922) and implement the other needed aspects of the pdf export.

Just to have a checklist, supposing the requirement to show the most of the relevant informations from the note itself:

  • Title
  • Text content (checklists must be shown correctly too)
  • Attachments (if they're images, otherwise placeholder icons)
  • Location (if present)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Omni Notes
  
To do
Development

Successfully merging this pull request may close these issues.

None yet

2 participants