Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdkafka-sys: don't build C++ libs #569

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcaesar
Copy link

@jcaesar jcaesar commented Apr 18, 2023

  • My motivation for this is to make cross-compiling easier. This gets rid of the need of a (working) C++ setup for cross compiling
  • A small speedup is a welcome side-effect
  • I have added this for both mklove and cmake builds, but I do feel like the CMake variant is a bit hacky, using the lib without installing it. If you think this is too brittle, I'd be happy to get only the mklove part accepted or hide it behind an env var.

@rukai
Copy link

rukai commented Sep 1, 2023

This PR works for me and reduces the size of target/build/rdkafka-sys-* from 45MB to 23MB which is quite nice.
Would really like to see this land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants