Add Timestamp to the OwnedDeliveryResult tuple.
#555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Note:** This is an API breaking change. Currently the `Timestamp` value is being dropped as part of the conversion from `BorrowedMessage` to `OwnedDeliveryResult`, however this value is updated once the message has been published and callers should have access to the updated value. As far as I can tell, this is the **only** other value that is updated as part of publishing. An alternative to expanding the tuple would be to replace it with a struct. This is a bit more disruptive now, but would making adding values in the future a backwards compatible change. So it depends how likely it is that there will be further new values. This could also be done in a way that isn't a breaking change, but would involve duplicating functions and copying some types, i.e. `DeliveryFuture`. It doesn't seem like that level of complexity is justified given the pre 1.0 status.
|
Any chance someone could take a look at this? I would like get our production systems off my fork if at all possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is an API breaking change.
Currently the
Timestampvalue is being dropped as part of the conversion fromBorrowedMessagetoOwnedDeliveryResult, however this value is updated once the message has been published and callers should have access to the updated value. As far as I can tell, this is the only other value that is updated as part of publishing.An alternative to expanding the tuple would be to replace it with a struct. This is a bit more disruptive now, but would make adding values in the future a backwards compatible change. So it depends how likely it is that there will be further new values.
This could also be done in a way that isn't a breaking change, but would involve duplicating functions and copying some types, i.e.
DeliveryFuture. It doesn't seem like that level of complexity is justified given the pre 1.0 status.