Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add member assignments parsing #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

messense
Copy link
Contributor

@messense messense commented Dec 2, 2019

No description provided.

@benesch
Copy link
Collaborator

benesch commented Dec 2, 2019

Hi, @messense, thanks for the PR! I'm afraid I don't think that this Rust wrapper of librdkafka is the correct place for this code. It seems like something that would be better handled by librdkafka itself. I've opened confluentinc/librdkafka#2643 to discuss.

I'm going to hold off on reviewing this PR until upstream responds!

@benesch
Copy link
Collaborator

benesch commented May 15, 2020

Hi @messense, sorry for the long delay. It looks like upstream, sadly, does not want to maintain this code, so I suppose we can take it here. It will need a test, though. If you can provide one, that would be great. Otherwise I'll try to get to it myself eventually.

@ianFar96
Copy link

Hi, do you still plan to merge this PR? It would be awesome to be able to access the topics consumed by a group

@benesch
Copy link
Collaborator

benesch commented May 27, 2023

Merging this PR is blocked on someone having time to write a test. If you are up for it, that would be great.

@ianFar96
Copy link

I started playing with rust a few weeks ago so I'm not feeling 100% confident about this. I'll give it a try and see what comes out of it. For the time being I can confirm that the proposed solution works as expected 👍

@ianFar96
Copy link

Hi, I expanded the test_group_membership test with this:

assert_eq!(consumer_member.assignment().unwrap().len(), 1);

let assignment_topic = &consumer_member.assignment().unwrap()[0];
assert_eq!(
    assignment_topic,
    &MemberAssignment {
        partitions: vec![0, 1, 2],
        topic: topic_name
    }
);

I hope it's enough, if it is how should I proceed? I don't have permissions to push on this branch, should I fork the fork and open another one?

@benesch
Copy link
Collaborator

benesch commented May 28, 2023

Yeah, that's probably good enough! A new PR sounds good.

@ianFar96 ianFar96 mentioned this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants