Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding behave test for get_source #1452

Merged
merged 21 commits into from
May 17, 2024
Merged

adding behave test for get_source #1452

merged 21 commits into from
May 17, 2024

Conversation

ahmadnazeri
Copy link
Contributor

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 16, 2024 16:44 — with GitHub Actions Inactive
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.73%. Comparing base (ccb04d8) to head (e10d1aa).
Report is 1 commits behind head on main.

Files Patch % Lines
client/src/featureform/grpc_client.py 25.00% 6 Missing ⚠️
client/src/featureform/register.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1452   +/-   ##
=======================================
  Coverage   57.72%   57.73%           
=======================================
  Files         195      195           
  Lines       26057    26063    +6     
  Branches      853      855    +2     
=======================================
+ Hits        15042    15047    +5     
+ Misses       9395     9394    -1     
- Partials     1620     1622    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 16, 2024 17:48 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 16, 2024 20:37 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 16, 2024 21:54 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 16, 2024 22:46 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri marked this pull request as ready for review May 16, 2024 23:18
@@ -134,5 +133,15 @@ def _limited_traceback(limit):
sys.tracebacklimit = original_limit


def _extract_error_details(e: grpc.RpcError) -> status_pb2.Status:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from oss

Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@aolfat aolfat temporarily deployed to Integration testing May 17, 2024 04:51 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing May 17, 2024 05:16 — with GitHub Actions Failure
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 17, 2024 06:09 — with GitHub Actions Inactive
@aolfat aolfat merged commit c9503b0 into main May 17, 2024
28 checks passed
@aolfat aolfat deleted the tests/get_source branch May 17, 2024 06:36
github-actions bot pushed a commit that referenced this pull request May 17, 2024
Co-authored-by: Ali Olfat <ali@featureform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants