Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equivalent: normalize sql whitespace and change statuses #1449

Merged
merged 5 commits into from
May 17, 2024
Merged

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented May 14, 2024

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat temporarily deployed to Integration testing May 14, 2024 16:25 — with GitHub Actions Inactive
@aolfat aolfat changed the title normalize sql Equals: normalize sql whitespace May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.79%. Comparing base (2c511c3) to head (a08e777).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
+ Coverage   57.73%   57.79%   +0.06%     
==========================================
  Files         195      195              
  Lines       26063    26075      +12     
  Branches      855      855              
==========================================
+ Hits        15047    15070      +23     
+ Misses       9394     9386       -8     
+ Partials     1622     1619       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aolfat aolfat had a problem deploying to Integration testing May 15, 2024 23:04 — with GitHub Actions Failure
@aolfat aolfat changed the title Equals: normalize sql whitespace Equivalent: normalize sql whitespace and change statuses May 15, 2024
@@ -124,6 +124,8 @@ message ResourceStatus {
PENDING = 2;
READY = 3;
FAILED = 4;
RUNNING = 5;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are in enterprise and not oss

@aolfat aolfat merged commit 9d2e07a into main May 17, 2024
27 of 28 checks passed
@aolfat aolfat deleted the normalize_sql branch May 17, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants