Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Properly extract status from trailing metadadta #1398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Mar 22, 2024

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat temporarily deployed to Integration testing March 22, 2024 03:19 — with GitHub Actions Inactive
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 56.21%. Comparing base (2198705) to head (61bae10).
Report is 3 commits behind head on main.

Files Patch % Lines
client/src/featureform/grpc_client.py 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
+ Coverage   55.99%   56.21%   +0.22%     
==========================================
  Files         189      190       +1     
  Lines       24761    24833      +72     
  Branches      840      846       +6     
==========================================
+ Hits        13864    13960      +96     
+ Misses       9366     9324      -42     
- Partials     1531     1549      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants