Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect thick line in variation tree at the first move #874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Feb 12, 2021

No description provided.

@hope366
Copy link

hope366 commented Feb 12, 2021

We were not able to confirm what changes occurred before and after the application of this PR.
I am observing the area shown by the screenshot below, is this correct?
Is the change so subtle that it is difficult to see with the eyes?
無題  

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Feb 17, 2021
@kaorahi kaorahi mentioned this pull request Feb 17, 2021
@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 17, 2021

Would you try this SGF on the default config.txt (normal UI) and compare its result with your previous screenshot?

(;B[aa])

@hope366
Copy link

hope366 commented Feb 17, 2021

I tried (;B[aa]) with normal UI + default config.
The line from the first move to the second move was thicker than usual. This thickness seems to depend on the value of "Winrate Stroke Width".
I had this setting set to "1" so I couldn't seem to find any difference.
The method of verification was insufficient. I would like to keep in mind to use the default config when checking for bugs.

@hope366
Copy link

hope366 commented Feb 17, 2021

I tried a little more verification.
If you create a branch like the one on the left, it will be a dotted line, but this also happened even if you set the Winrate Stroke Width to "1".
Next, look at the figure on the right.
In this way, when the movement of the main tree is fixed at "1", the subbranch line seems to be a "thick wrong line" forever.(Only if the current move exists in the root node or in the "1" move of the main tree.)
This PR seems to solve these as well.

無題1 無題

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants