-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pseudo-random neutrino velocity #98
Open
adrianbayer
wants to merge
175
commits into
master
Choose a base branch
from
pseudorandom_v
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastpm_store_write already support "r" mode for reading. fastpm_store_read is just an alias. I think we shall eventually refactor the routines in io.c to a FastPMSerializer object, which does read, write, append, and read_header, write_header. What we have now is likely good enough for now.
Tested that restarted run has identical velocity dispersion every step, when the restarted snapshot is exactly on a time step. There is still a glitch that after restart we immediately write an output.
Abacus has no radiation in background, so cannot use the FD formulations because Omega_ncdm ~ Omega_gamma.
Potential fix for #92.
Move the memory allocation around accordingly
This reverts commit b0f8446.
I did a complicated rebase where I essentially just copied over the new code whenever there was a conflict, so looking through all the history may not be meaningful. Relevant final commit before rebase is already changed nn to every in lua, but now change fastpm.c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is unfinished from one year ago, but wanted to push it so that it wasn't lost in case we decide to develop it further.