Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Comet Callback documentation #4009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lothiraldan
Copy link

The current Comet callback is broken. The Comet team is now maintaining it inside the Comet SDK. Update the documentation to point to the new version of the callback.

The current Comet callback is broken. The Comet team is now maintaining it
inside the Comet SDK. Update the documentation to point to the new version of
the callback.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Lothiraldan
Copy link
Author

I wasn't sure exactly what to do with the current Callback in fastai repository (https://github.com/fastai/fastai/blob/master/fastai/callback/comet.py). Given that it's broken when you try to instantiate the callback:

File ~/.virtualenvs/comet3.9/lib/python3.9/site-packages/fastai/callback/comet.py:24, in CometCallback.__init__(self, project_name, log_model_weights)
     22 def __init__(self, project_name, log_model_weights=True):
     23     self.log_model_weights = log_model_weights
---> 24     self.keep_experiment_running = keep_experiment_running
     25     self.project_name = project_name
     26     self.experiment = None

NameError: name 'keep_experiment_running' is not defined

I think it's safe to delete the comet module. Alternatively, we can update the current callback to show a warning pointing to the new one maintained by Comet. Please let me know what do you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant