-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go bindings to version merged into nixos/nix #2
base: master
Are you sure you want to change the base?
Conversation
I looked through this and the code is very clean, great job. Accessing the strings is so much nicer with the new API, too. |
@marcusramberg do you think there's anything else worth doing there or you're good with flipping the draft bit on this and merging it in? |
I think the only concern I have is the failing test for path. It's unclear to me why it's returning /foo/bar for ./foo/bar input. ( https://github.com/farcaller/gonix/pull/2/files#diff-864944c880a2e4db1b8f93f33a58303d840fb4b6c50147cc2f915c6d48f7bf2cL173) |
I think this is blocked by NixOS/nix#10613. If it's "nix_init_path_from_absolute_path_string" indeed, then our test is broken. |
I suggest we update the test case to use the absolute paths and merge this. We can revisit the behavior once NixOS/nix#10613 makes progress. |
oki. I just tested updating the flake to nix master, and there's a new failure in the primop test:
I'll try to address that and change the test this weekend, and undraft the PR? |
Updated the deps again today, and seems the issue was fixed upstream. All tests pass now. |
Seems the fix was NixOS/nix@ |
Opening this for discussion, currently it builds but has one test failure related to paths (leading . is stripped).