Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentWillMount -> componentDidMount #29

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

componentWillMount -> componentDidMount #29

wants to merge 6 commits into from

Conversation

wpitallo
Copy link

componentWillMount -> componentDidMount

@johnvehr
Copy link

@fangpenlin Hey what is the status of this pull request. I believe this will fix some things for newer versions of react. Currently it is failing. Thanks

@informagico
Copy link

@fangpenlin big UP for this pull request, it fix the annoying deprecation warning

@yayvery
Copy link

yayvery commented Jul 9, 2020

This causes it to render an empty face.

@soulteary
Copy link

This causes it to render an empty face.

@danb10 For the correct solution, you can refer to this PR:
#44

Or install a temporary replacement package in this PR:
#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wpitallo @johnvehr @informagico @yayvery @soulteary