-
Notifications
You must be signed in to change notification settings - Fork 55
feat: use defined signs for diagnostics provider #331
base: master
Are you sure you want to change the base?
Conversation
Not sure if it's a thing with my config or if it's an issue for everyone, but, it seems that if |
This is true. I removed the fallback and also return However, now that I think about it, there might be some user that uses lsp without |
Seems like it's a Neovim core thing and thus is unaffected by whether |
Turns out we do need some form of fallback, since the signs are only defined only after diagnostics are shown, they are still undefined until then. Also using |
But as long as there are not diagnostics, the icon will never show, therefore it should be acceptable that the icon is undefined until then. Also using Which is my usecase -- I want uniform icons across all UI elements. However, this can also be achieved using the |
That is not true. There is nothing (except an |
Hey, first of all, thanks for creating feline.nvim.
This pull requests tries to get the text field of the defined signs created by the LSP (i.e. DiagnosticSignError, DiagnosticSignWarn, DiagnosticSignInfo, DiagnosticSignHint) instead of using the hardcoded icons. The hardcoded icons are however used as a fallback.