Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline trim functions #659

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

eirnym
Copy link
Contributor

@eirnym eirnym commented Dec 21, 2021

No description provided.

@eirnym
Copy link
Contributor Author

eirnym commented Dec 21, 2021

Which cpp version do you use?

Mine is following:

Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

UPDATE: clang 10 works perfectly as well

clang version 10.0.1 
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /opt/local/libexec/llvm-10/bin

@alexeevdv
Copy link
Contributor

alexeevdv commented Dec 22, 2021

It would be great to make them generic then. Could you please add possibility to trim any symbol and not just space?

@eirnym
Copy link
Contributor Author

eirnym commented Dec 22, 2021

It would be great to make them generic then
Yes, I think it's possible.

@alexeevdv could you please check why it doesn't want to compile on Ubuntu? Should I install another compiler?

@eirnym
Copy link
Contributor Author

eirnym commented Dec 22, 2021

This project doesn't have any tests. Which test suite do you prefer? Google tests, CTests or something else?

@alexeevdv
Copy link
Contributor

I do not see any use of tests at this point

@eirnym
Copy link
Contributor Author

eirnym commented Dec 22, 2021

I'd love to introduce them

@alexeevdv
Copy link
Contributor

I would like to see tests in separate branch then. Do not mix it with any other changes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants