Prevent dangling pointers when removing obj from map. Closes #531, closes #538 #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JanSimek seems like a sane use of the aliasing ctor for now (I have learnt something myself: I've never used this). But yeah, I'm guessing the long-term plan is to make the various methods take smart pointers / references in future to reduce these kinds of lifetime issues. |
|
I confirm this fixes crash when accessing shelves container at desrt11.map |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the crash simply load the
artemplemap and open the inventory.Use aliasing constructor until we unravel the mix of raw and smart pointers.
@adamkewley I do not have much experience with smart pointers but this seems like the easiest fix for now