Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(engine): add print_enabled_rules_falco_logger when log_level debug #3189

Merged

Conversation

incertum
Copy link
Contributor

@incertum incertum commented May 8, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

add print_enabled_rules_falco_logger when log_level debug similar to how we print the final set of syscalls of interest.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(engine): add print_enabled_rules_falco_logger when log_level debug

Copy link

github-actions bot commented May 8, 2024

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@incertum incertum force-pushed the add_updated_enabled_to_falco_rule_object branch from 9588ba7 to 09cb8d6 Compare May 13, 2024 22:00
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
@incertum incertum force-pushed the add_updated_enabled_to_falco_rule_object branch from 09cb8d6 to 8eef3db Compare May 15, 2024 20:01
@poiana poiana added size/S and removed size/L labels May 15, 2024
@incertum incertum changed the title wip: new(engine): explicitely add enabled property to falco_rule and keep up-to-date new(engine): add print_enabled_rules_falco_logger when log_level debug May 15, 2024
@incertum
Copy link
Contributor Author

/unhold

/milestone 0.38.0

@LucaGuerra as discussed a lean patch for now.

@poiana poiana added this to the 0.38.0 milestone May 15, 2024
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
@poiana poiana added size/M and removed size/S labels May 16, 2024
Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@poiana
Copy link

poiana commented May 16, 2024

LGTM label has been added.

Git tree hash: 10df2bbb1acaf186981678cd735408a659d727e5

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6057c15 into falcosecurity:master May 16, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants