fix(userspace/engine): make sure exception fields are not optional in replace mode #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
|
Could you please add a test for this behavior? This way we won't break it in the future. |
|
/milestone 0.38.0 |
… replace mode Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
fix/exceptions-replace-fields-optional
branch
from
fc63582
to
8de17fb
Compare
LucaGuerra
reviewed
May 16, 2024
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
LucaGuerra
approved these changes
May 17, 2024
|
LGTM label has been added. Git tree hash: 201862dc1d9651dcafa33c7ea163dfd7a6e4fdf3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
When replaced with the new
overrideYAML construct,exceptionsmust not have any of their sub-fields as optional, just like when first defined in regular rules definitions.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: