-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--[BE Week]Modify ESP_CHECK to exit not abort. #2143
Open
jturner65
wants to merge
1
commit into
main
Choose a base branch
from
BE_EspCheckRework
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Jun 30, 2023
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
July 6, 2023 10:06
07a405e
to
1b998f7
Compare
Skylion007
approved these changes
Jul 7, 2023
jturner65
force-pushed
the
BE_EspCheckRework
branch
from
August 17, 2023 13:15
1b998f7
to
c1f24c1
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
4 times, most recently
from
September 27, 2023 19:13
d4a44be
to
5892a01
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
from
October 10, 2023 13:00
5892a01
to
91bedc7
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
from
November 14, 2023 16:27
91bedc7
to
7dfabe1
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
November 29, 2023 14:40
e8deb90
to
a5c2fb0
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
4 times, most recently
from
December 12, 2023 17:24
83e06d3
to
3c6be66
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
from
December 18, 2023 17:18
3c6be66
to
9b8b14f
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
January 4, 2024 13:52
3a2fe6c
to
5016d85
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
January 9, 2024 21:16
94ac25a
to
9f83102
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
January 29, 2024 19:22
162c2aa
to
09435f6
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
February 5, 2024 14:07
1d05c99
to
da65296
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
February 13, 2024 14:14
9bebdda
to
9908091
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
February 21, 2024 14:36
d871b46
to
4a28df1
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
February 29, 2024 16:50
b4b398b
to
d9f952f
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
3 times, most recently
from
March 5, 2024 18:46
0e29cd9
to
5b90d51
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
4 times, most recently
from
March 20, 2024 16:14
a4aa4fe
to
2862bdd
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
April 8, 2024 14:04
5b3a484
to
013b102
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
2 times, most recently
from
April 22, 2024 13:33
56c082b
to
daa7e2b
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
4 times, most recently
from
May 2, 2024 13:20
bc4bc8f
to
1dde8a6
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
3 times, most recently
from
May 9, 2024 13:45
8bcb838
to
a0d52e5
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
from
May 13, 2024 11:04
a0d52e5
to
a6d16aa
Compare
jturner65
force-pushed
the
BE_EspCheckRework
branch
from
May 13, 2024 18:50
a6d16aa
to
4db7335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently our ESP_CHECK macro was exiting the program via std::abort(), providing a core dump. However, it is most often used to verify data or check the results of file IO, for which a core dump is undesirable. This PR changes ESP_CHECK to std::exit(1) instead, avoiding the core dump.
An alternative mechanism that provides the assertion-like behavior with the std::abort/core dump functionality while also communicating with python properly is being investigated for a future PR.
How Has This Been Tested
All current c++ and python tests pass.
Types of changes
Checklist