Skip to content

Commit

Permalink
Fix version string in conda builds.
Browse files Browse the repository at this point in the history
Summary: Currently, conda version strings are built from the latest git tag, which starts with the letter `v`. This confuses conda, which orders v1.6.5 before 1.6.3.

Reviewed By: LowikC

Differential Revision: D25151276

fbshipit-source-id: 7abfb547fee3468b26fedb6637a15e725755daf3
  • Loading branch information
Lucas Hosseini authored and facebook-github-bot committed Nov 22, 2020
1 parent f171d19 commit 88eabe9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion conda/faiss-gpu/meta.yaml
Expand Up @@ -3,7 +3,7 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

{% set version = GIT_DESCRIBE_TAG %}
{% set version = environ.get('GIT_DESCRIBE_TAG').lstrip('v') %}
{% set number = GIT_DESCRIBE_NUMBER %}

package:
Expand Down
2 changes: 1 addition & 1 deletion conda/faiss/meta.yaml
Expand Up @@ -3,7 +3,7 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

{% set version = GIT_DESCRIBE_TAG %}
{% set version = environ.get('GIT_DESCRIBE_TAG').lstrip('v') %}
{% set number = GIT_DESCRIBE_NUMBER %}

package:
Expand Down

0 comments on commit 88eabe9

Please sign in to comment.