Allow redundant dots in JSON paths accepted by json_extract[_scalar] Presto #9585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56467690 |
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
approved these changes
Apr 23, 2024
| /// equivalent. This is not part of JSONPath syntax, but this is the behavior of | ||
| /// Jayway implementation used by Presto. | ||
| /// | ||
| /// It is allowed to use dot-notation redundantly, e.g. non-standaed path |
xiaoxmeng
approved these changes
Apr 23, 2024
mbasmanova
force-pushed
the
export-D56467690
branch
from
774e0d7
to
27b0cd6
Compare
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 23, 2024
…Presto (facebookincubator#9585) Summary: json_extract_scalar and json_extract Presto function allow paths like '$.[0]. [1].[2].foo' that include "redundant" dots before opening brackets. These paths are non-standard. They are enabled via use of Jayway engine. This change allows Velox to support these paths by ignoring dots that appear before opening brackets. See prestodb/presto#22589 Part of facebookincubator#7049 Reviewed By: xiaoxmeng Differential Revision: D56467690
…alar] Presto functions (facebookincubator#9584) Summary: json_extract_scalar and json_extract Presto function allow paths like 'foo' and 'foo.bar'. These paths are non-standard. They are enabled via use of Jayway engine, which handles paths without leading '$' by prepending the path with '$.'. Path 'foo' becomes '$.foo'. However, this logic has some unexpected side effects. Path '.foo' becomes '$..foo', which uses deep scan operator '..' and matches 'foo' keys anywhere in the document, rather then just at the top level. This change allows Velox to support paths like 'foo' and 'foo.bar[2].bar', but not '.foo' or '[10]'. These paths are handled as if they contained leading '$.' characters. See prestodb/presto#22589 Part of facebookincubator#7049 Differential Revision: D56465662
…Presto (facebookincubator#9585) Summary: json_extract_scalar and json_extract Presto function allow paths like '$.[0]. [1].[2].foo' that include "redundant" dots before opening brackets. These paths are non-standard. They are enabled via use of Jayway engine. This change allows Velox to support these paths by ignoring dots that appear before opening brackets. See prestodb/presto#22589 Part of facebookincubator#7049 Reviewed By: xiaoxmeng Differential Revision: D56467690
|
This pull request was exported from Phabricator. Differential Revision: D56467690 |
mbasmanova
force-pushed
the
export-D56467690
branch
from
27b0cd6
to
c05d5fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56467690 |
|
This pull request has been merged in 2a67b6e. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
json_extract_scalar and json_extract Presto function allow paths like '$.[0].
[1].[2].foo' that include "redundant" dots before opening brackets. These paths
are non-standard. They are enabled via use of Jayway engine.
This change allows Velox to support these paths by ignoring dots that appear
before opening brackets.
See prestodb/presto#22589 Part of
#7049
Differential Revision: D56467690