This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
keyPath property animations #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue where UIEdgeINsets was not ifdef'd out for PHONE only.
* master: Update podspec to 1.0.8.
Open
b3ll
reviewed
Mar 23, 2017
There was a problem hiding this comment.
This is pretty rad. The only thing I'm concerned with is the overhead introduced by executing -valueForKeyPath: every frame (rather than directly accessing the property itself). It's not a major concern, but I'd rather -animationForKeyPath: not become the default use-case.
pop/POPAnimatablePropertyInternal.h
Outdated
| // Created by Alexander Cohen on 2015-09-16. | ||
| // Copyright © 2015 Facebook. All rights reserved. | ||
| // | ||
|
|
There was a problem hiding this comment.
can we get this header setup to be the same as the other headers? :D
| [(CALayer*)[layer expect] setPosition:FBTestInterpolateLinear(Vector2r([anim.fromValue CGPointValue]), Vector2r([anim.toValue CGPointValue]), 0.25).cg_point()]; | ||
| [(CALayer*)[layer expect] setPosition:FBTestInterpolateLinear(Vector2r([anim.fromValue CGPointValue]), Vector2r([anim.toValue CGPointValue]), 0.5).cg_point()]; | ||
| [(CALayer*)[layer expect] setPosition:FBTestInterpolateLinear(Vector2r([anim.fromValue CGPointValue]), Vector2r([anim.toValue CGPointValue]), 0.75).cg_point()]; | ||
| [(CALayer*)[layer expect] setPosition:[anim.toValue CGPointValue]]; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added keyPath to POPPropertyAnimation
This enables POPPropertyAnimation.property to be automatically filled in by the engine instead of having to enter it yourself.
That code will have the engine first check the object it was added to for a method named animationPropertyForContentOffset. If found, it will be called to fill in the property. If not, the engine will then call [object valueForKeyPath:keyPath] in order to figure out what kind of value should be passed around. Then it sets up the property for that that type of value.
Slipped in GLKit data type support
2 new types were added, GLKVector3 and GLKQuaternion. GLKVector3 can be used everywhere and GLKQuaternion can be used everywhere except for velocities.