This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix vulnerability related to ACK/NAK handling (CVSS score: 7.2) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whole range into account - added new RangeList::IsWithinRange() method - several changes to RangeList::Deserialize() to prevent invalid RangeLists being constructed from a bitstream (incl. preventing overlapping and duplicated ranges)
- early out when processing ACK/NAK ranges, if end of datagram history reached
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of a security relevant fix for RakNet (fixes second part of issue #102) which was brought to our attention by a user - see SLikeSoft#32 for details. The issue has already been fixed in SLikeNet 0.1.2 (see https://www.slikenet.com/).
We provide this backport for people who prefer to stick with the RakNet project and also in order to easier share this fix with other RakNet forks.
CVSS Base score: 7.5
CVSS Temporal score: 7.2
CVSS Overall score: 7.2
CVSS v3 vector: AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H/E:H/RL:O/RC:C
This fix works in combination with pull request #127. Therefore, both pull requests must be applied to completely resolve the issue.
The security implications are critical in our opinion. Every RakNet instance is susceptive to the attack. No authentication is required. If the attack is successful, the instance will become unresponsive for as long as the attack goes on (and quite a while afterwards - DoS attack). If the attack stops, the server will become responsible again eventually.
If an upgrade of the server side is not reasonable to resolve the vulnerability, we offer alternative approaches to mitigate attacks relying on this issue. Please contact us at security@slikesoft.com.