Make SystraceSection feed into Instruments signposts API #44496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56280451 |
Base commit: 5a6b64f |
lyahdav
added a commit
to lyahdav/react-native
that referenced
this pull request
May 9, 2024
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Differential Revision: D56280451
|
This pull request was exported from Phabricator. Differential Revision: D56280451 |
lyahdav
added a commit
to lyahdav/react-native
that referenced
this pull request
May 9, 2024
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Differential Revision: D56280451
|
This pull request was exported from Phabricator. Differential Revision: D56280451 |
lyahdav
added a commit
to lyahdav/react-native
that referenced
this pull request
May 17, 2024
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Reviewed By: sammy-SC Differential Revision: D56280451
|
This pull request was exported from Phabricator. Differential Revision: D56280451 |
lyahdav
added a commit
to lyahdav/react-native
that referenced
this pull request
May 18, 2024
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Reviewed By: sammy-SC Differential Revision: D56280451
|
This pull request was exported from Phabricator. Differential Revision: D56280451 |
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Reviewed By: sammy-SC Differential Revision: D56280451
|
This pull request was exported from Phabricator. Differential Revision: D56280451 |
|
This pull request has been merged in 840c31c. |
|
This pull request was successfully merged by @lyahdav in 840c31c. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS.
Changelog:
[iOS][Added] - Add Instruments signposts API for SystraceSection
Differential Revision: D56280451