-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SystraceSection feed into Instruments signposts API #44496
Conversation
This pull request was exported from Phabricator. Differential Revision: D56280451 |
Base commit: 5a6b64f |
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Differential Revision: D56280451
This pull request was exported from Phabricator. Differential Revision: D56280451 |
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Differential Revision: D56280451
This pull request was exported from Phabricator. Differential Revision: D56280451 |
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Reviewed By: sammy-SC Differential Revision: D56280451
This pull request was exported from Phabricator. Differential Revision: D56280451 |
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Reviewed By: sammy-SC Differential Revision: D56280451
This pull request was exported from Phabricator. Differential Revision: D56280451 |
) Summary: When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS. Changelog: [iOS][Added] - Add Instruments signposts API for SystraceSection Reviewed By: sammy-SC Differential Revision: D56280451
This pull request was exported from Phabricator. Differential Revision: D56280451 |
This pull request has been merged in 840c31c. |
This pull request was successfully merged by @lyahdav in 840c31c. When will my fix make it into a release? | How to file a pick request? |
Summary:
When doing performance profiling on a React Native iOS app and trying to identify bottlenecks on the native side it can be helpful to correlate actions to what is happening inside React Native. We already have the SystraceSection class for this, but it does nothing in open source. This diff allows SystraceSection to feed into the Instruments signpost API on iOS/macOS.
Changelog:
[iOS][Added] - Add Instruments signposts API for SystraceSection
Differential Revision: D56280451