Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag-and-drop example using Litho #893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

conca
Copy link

@conca conca commented Mar 10, 2022

I'm trying to implement drag-and-drop using DataDiffSection, but it doesn't work properly. In general, I'm able to drag items within the RecyclerView. However, the interaction feels a bit weird.

@facebook-github-bot
Copy link
Contributor

Hi @conca!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@adityasharat
Copy link
Contributor

@conca can you sign the CLA, that would enable me to pull this PR into our source control.

@conca
Copy link
Author

conca commented Jun 13, 2022

Sorry for the delay. I totally missed your message. This was just an example of drag-and-drop (that is actually not working as expected) for Pasquale to check and identify what is wrong. Do you still need the signature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants