Restart input if imeOptions are changed in TextInputSpec #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change modifies TextInputSpec to restart input if imeOptions are changed.
This is needed because if imeOptions are changed when the keyboard is visible, the new imeOptions are not reflected on the keyboard unless restartInput is called. Since there isn't a reliable way to check if the keyboard is visible or not on Android, restartInput should be called whenever imeOptions are changed.
Changelog
Call restartInput if imeOptions are changed in TextInputSpec.
Test Plan
Tested manually. Before the change, changing imeOptions while the keyboard is visible doesn't change the action key to the correct type. After the change, changing imeOptions while the keyboard is visible results in the action key being updated to the correct type. As far as I know, there isn't a way to verify this programatically.