-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back to LEGACY mode for Robolectric to test CI #768
base: master
Are you sure you want to change the base?
Conversation
This pull request was exported from Phabricator. Differential Revision: D26400588 |
Summary: Pull Request resolved: facebook#768 Differential Revision: D26400588 fbshipit-source-id: a177515bbe5e9e91afb4d1224e73edbf0f8d6725
f2fa94e
to
7b6f203
Compare
This pull request was exported from Phabricator. Differential Revision: D26400588 |
Hi @colriot , would it make sense instead of executing all litho tests with LEGACY, to only annotate the tests that need LEGACY and let all other tests run with PAUSED? I believe Robolectric LooperMode.LEGACY is now considered deprecated. I have sent a couple of PRs to annotate with LEGACY the tests that need it. Please let me know your thougths. |
Summary: Pull Request resolved: facebook#768 Differential Revision: D26400588 fbshipit-source-id: 82ed3e8ee44b3bc76270b24319d869327981f96a
7b6f203
to
e6aacc1
Compare
This pull request was exported from Phabricator. Differential Revision: D26400588 |
Hi @chggr! I'm just trying to debug a tests issue on CI. As you've probably noticed we now have red CI in OSS (though it's green internally). And I'm trying to fix it. I've also added quite a bunch of Legacy annotations to our tests some time around your PRs :) So, I wanted to ask you to rebase your 2 PRs on top of master, to actualize and merge them |
Differential Revision: D26400588