New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Testslide to typeguard 3.02 #352
Open
williamlw999-fb
wants to merge
1
commit into
facebook:main
Choose a base branch
from
williamlw999-fb:Typeguard_upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Apr 10, 2023
williamlw999-fb
force-pushed
the
Typeguard_upgrade
branch
from
April 10, 2023 19:13
898ba65
to
bcb5370
Compare
williamlw999-fb
force-pushed
the
Typeguard_upgrade
branch
from
April 10, 2023 19:16
bcb5370
to
3374d34
Compare
Pull Request Test Coverage Report for Build 4660484186
💛 - Coveralls |
@williamlw999-fb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Now that typeguard is at 4.0.0, it would be good to have support for that as well. It looks like it will be as simple as loosening the version bound: From f7d1c5c22f5d795463a8b5d614d50f643cc81d71 Mon Sep 17 00:00:00 2001
From: "Benjamin A. Beasley" <code@musicinmybrain.net>
Date: Fri, 12 May 2023 08:45:24 -0400
Subject: [PATCH] Allow typeguard 4.x
---
requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/requirements.txt b/requirements.txt
index a87cb58..cc27889 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
psutil>=5.6.7
Pygments>=2.2.0
-typeguard~=3.0
+typeguard>=3.0,<5
dataclasses>=0.6; python_version < "3.7"
--
2.39.2 |
shish
added a commit
that referenced
this pull request
Mar 25, 2024
Wanting to try out "upgrade typeguard to 3.X" (#352) and "upgrade typeguard to 4.X" in parallel, pulling some superficial parts out so that I can minimise distractions
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Summary: Pull superficial changes out of #352 Wanting to try out "upgrade typeguard to 3.X" (#352) and "upgrade typeguard to 4.X" in parallel, pulling some superficial parts out so that I can minimise distractions Pull Request resolved: #358 Differential Revision: D55365453 Pulled By: shish fbshipit-source-id: 7f09e9586cef2d810d069e7b723358f7f2f4a40f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Upgrading to Typeguard 3.02
Why:
Keep Testslide up to date
How:
check_type
Typeguard mock to instead mock._checkers.check_type_internal
qualified_name
Typeguard mock target to internal._utils.qualified_name
typeguard.TypeCheckError
Misc.
Risks:
Some error message formats have changed
Checklist: