Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded @preact/signals-react to 2.0.0 #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

awhitford
Copy link

Fixes #188

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for modularforms ready!

Name Link
🔨 Latest commit 8c6d962
🔍 Latest deploy log https://app.netlify.com/sites/modularforms/deploys/65ee80b14cd60b0008bde7df
😎 Deploy Preview https://deploy-preview-191--modularforms.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fabian-hiller fabian-hiller self-assigned this Mar 11, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Mar 11, 2024
@fabian-hiller
Copy link
Owner

Awesome! Thank you! I plan to check and merge it tomorrow or in the next few days.

@fabian-hiller
Copy link
Owner

I need more time for other stuff. I am very sorry. I will get back to you as soon as I can.

@fabian-hiller
Copy link
Owner

I started reviewing this PR and noticed that `@preact/signals-react-transform' adds a lot of unnecessary stuff to our build files. I wonder if this is really necessary. It seems to me that the babel transform step should only be done by apps and not by libraries like Modular Forms. I will investigate this further in the next few minutes.

@fabian-hiller
Copy link
Owner

Unfortunately, our playground/react seems to be broken after the upgrade and I do not have time to investigate further. If you are able to fix it, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[React]: Preact Signals Dependency Update
2 participants