Wait run to finish and exit code #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maks3w
force-pushed
the
wait-run-to-finish-and-exit-code
branch
from
f5dd343
to
3e5a5b0
Compare
|
👍 Just what I was looking for, this works great for multi mode binaries where one mode is a service but want to do adhoc tasks on the same task definition by overriding the command. Worked well in my local testing. Thanks! |
Maks3w
force-pushed
the
wait-run-to-finish-and-exit-code
branch
2 times, most recently
from
48d8c56
to
c408c39
Compare
Maks3w
force-pushed
the
wait-run-to-finish-and-exit-code
branch
from
c408c39
to
dea604c
Compare
Maks3w
force-pushed
the
wait-run-to-finish-and-exit-code
branch
from
dea604c
to
92bd71b
Compare
|
Would really appreciate to have this feature in the next release! Thank you for your work guys! |
|
This PR has some of the same commits as this PR https://github.com/fabfuel/ecs-deploy/pull/83/commits which has a pending review comment. It would be nicer if you cherry-pick this commit 92bd71b into this PR without including the other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default way of run to work
Actually run command just fire and forget the task.
This PR changes the behavior in two ways:
a. Wait for the task to finish (Same behavior as desploy task,
--timeout -1do fire-and-forget`b. Returns and exit_code > 0 if any of the tasks returns with that value
This PR is on top of #83 and adds f5dd343