Fix deployment rollbacking with more than 100 tasks #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've tested a deployment with more than 100 tasks and it went through this time! |
The `list_tasks` call was capped at 100 tasks, if your service had a desired superior of 100 the deployment would fail. Fix fabfuel#174 Signed-off-by: Adrien Fillon <adrien.fillon@manomano.com>
|
Yeah, this doesn't work if >100 tasks. Deployment times out despite having completed on the ECS side. Any chance of this getting merged? |
|
We ran into a similar issue this past week regarding timeouts when more than 100 tasks were running. This PR looks like it solves the issue in a way more inline with the existing code base while the strategy that my team took was to ignore counting tasks altogether by checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
list_taskscall was capped at 100 tasks, if the service had a desiredsuperior of 100 the deployment would fail.
Fix #174
Signed-off-by: Adrien Fillon adrien.fillon@manomano.com