-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backface Culling Additions #1421
base: master
Are you sure you want to change the base?
Conversation
Added command line for backface culling at "ConfigurationOptions::GetOptions"
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
- Coverage 96.55% 96.51% -0.05%
==========================================
Files 103 103
Lines 7555 7570 +15
==========================================
+ Hits 7295 7306 +11
- Misses 260 264 +4 ☔ View full report in Codecov by Sentry. |
…x/.h -Added `SetUseBackface` call in window_impl.cxx -Modified command name for backface culling in `options.cxx` and `F3DOptionsParser.cxx` -Changed attribute name for backface to `UseBackface`
@@ -345,6 +345,7 @@ void ConfigurationOptions::GetOptions(F3DAppOptions& appOptions, f3d::options& o | |||
this->DeclareOption(grp2, "point-type", "", "Point sprites type when showing point sprites", options.getAsStringRef("model.point-sprites.type"), HasDefault::YES, MayHaveConfig::YES, "<sphere|gaussian>"); | |||
this->DeclareOption(grp2, "point-size", "", "Point size when showing vertices or point sprites", options.getAsDoubleRef("render.point-size"), HasDefault::YES, MayHaveConfig::YES, "<size>"); | |||
this->DeclareOption(grp2, "line-width", "", "Line width when showing edges", options.getAsDoubleRef("render.line-width"), HasDefault::YES, MayHaveConfig::YES, "<width>"); | |||
this->DeclareOption(grp2, "backface", "", "Backface default (visible) or hidden", options.getAsStringRef("render.backface"), HasDefault::YES, MayHaveConfig::YES, "<default|hidden>"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think default should be unchanged.
possible value:
- default
- visible
- hidden
Added "SetBackfaceCulling()" at "vtkF3DRenderer::ConfigureActorsProperties()".
Added "BackfaceCullingVisible" in class "vtkF3DRenderer".
Added CheatSheet text at "vtkF3DRenderer::FillCheatSheetHotkeys" for backface culling.