Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Add automatic font-face embedding #29

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

nsonnad
Copy link
Contributor

@nsonnad nsonnad commented May 11, 2015

As discussed in #24, PNG downloading does not work. However the in-browser test does pass. I'm not sure how bulletproof the XHR code is or whether there might be any cross-domain issues.

@nsonnad nsonnad mentioned this pull request May 11, 2015
@rediris
Copy link

rediris commented Oct 8, 2015

@exupero any chance of merging this pull request?

@rediris
Copy link

rediris commented Oct 9, 2015

@nsonnad I'm getting a warning in Chrome v45:
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/. at line 31: https://github.com/nsonnad/saveSvgAsPng/blob/inline-fonts/saveSvgAsPng.js#L31

@exupero
Copy link
Owner

exupero commented Oct 11, 2015

These changes don't appear to be working in Firefox. I was able to get a PNG in Webkit with the embedded font.

I'm willing to merge with the synchronous requests and refactor them to be async later, but it should work in Firefox. I'm getting the same synchronous request warning as Chrome, but no errors, so I don't have any other pointers to what's not working.

@rediris
Copy link

rediris commented Oct 16, 2015

Yes, I'm getting "GET" errors in Firefox's console. Evidently something about the font relative URL is getting handled differently by FF.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants