Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ratatui to latest release #2100

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Update ratatui to latest release #2100

wants to merge 4 commits into from

Conversation

spk
Copy link

@spk spk commented Feb 25, 2024 •
edited

This Pull Request is related to (#2094, #2098)

It changes the following:

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@spk
Update ratatui to 0.25.0
b29f76d
@spk
Update ratatui to 0.26.1
dcf4bbd
@spk
Add entry to the changelog about ratatui update
fa3e7bf
@spk
Fix clippy error
4af7b00 
```
error: avoid using `collect()` when not needed
  --> src/ui/scrolllist.rs:52:33
   |
52 |             self.items.map(ListItem::new).collect::<Vec<ListItem>>(),
   |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this call
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
note: the lint level is defined here
```
@spk
Copy link
Author

spk commented Feb 25, 2024

I have a test failure locally not sure why

failures:

---- ui::style::tests::test_smoke stdout ----
thread 'ui::style::tests::test_smoke' panicked at src/ui/style.rs:379:9:
assertion failed: `(left == right)`

Diff < left / right > :
<Blue
>White

@extrawurst
Copy link
Owner

see #2079 - we first have to wait for a new ratatui release with a fix for ratatui-org/ratatui#961 (comment)

@extrawurst extrawurst marked this pull request as draft February 25, 2024 11:03
@extrawurst extrawurst mentioned this pull request Mar 26, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spk @extrawurst