Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eas env commands #2350

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khamilowicz
Copy link
Contributor

@khamilowicz khamilowicz commented Apr 29, 2024

Why

Implements the following commands:

Also, as discussed on Linear, implements eas env:shared:create/update/get/delete/link/unlink as --scope shared flag on mentioned commands. (ENG-11927, ENG-11926, ENG-11925, ENG-11921, ENG-11922, ENG-11923).

How

Created commands and mutations using updated backend (https://github.com/expo/universe/pull/15153).

Deployment

  1. https://github.com/expo/universe/pull/15153
  2. Implement eas env commands #2350

Test Plan

Each command accepts arguments both in interactive mode (user is prompted for input) and non-interactive (arguments are passed inline).

The following flow will create both project and shared variables, then it will link and unlink shared variable from the project, and finally delete both of them. Commands are executed both with inline arguments and prompts.
From an existing app directory:

  1. Create project variable interactively - eas env:create and provide name, value and select environment
  2. Create shared variable non-interactively - env:create --scope SHARED --name sharedVariable --value someValue
  3. eas env:list and select environment - displays only project var
  4. eas env:list --format long --scope SHARED - displays only shared var in long format
  5. eas env:link - select shared var and environment
  6. eas env:list - shared variable should be added to selected env
  7. eas env:unlink --environment SELECTEDENV --name sharedVariable
  8. eas env:list - shared variable should be removed
  9. eas env:delete - delete project variable
  10. eas env:delete --scope SHARED - delete shared environment

Copy link

linear bot commented Apr 29, 2024

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11913-add-eas-envcreate-command branch 2 times, most recently from f5e40bf to 78ebc5b Compare April 30, 2024 11:08
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11913-add-eas-envcreate-command branch from 78ebc5b to 5c5e337 Compare May 6, 2024 10:27
Copy link

github-actions bot commented May 6, 2024

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you.
🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message].
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant