[WIP][do not merge][RFC] feat: support for development provisioning profiles (iOS)

[fobos531]

Why

When adding a Tap To Pay on iPhone feature to my app, I found myself needing to use the Development provisioning profiles to sign the app. In initial phases of the development of this feature, Apple usually only grants you this entitlement for the Development provisioning profiles - it has proven to be a big hassle to manage these profiles manually, so I'm looking into adding the support for this right into eas-cli

How

1:1 implementation based on the AdHoc feature. Added development distribution method everywhere I could find. On Android, it behaves exactly the same as internal, so iOS is essentially the only platform where stuff got changed. I assume there might be places that require upstream changes, like e.g. @expo/eas-build-job to fully add support for this. Right now, my implementation ends up with a lot of duplicated code in the iOS part of the implementation (AdHoc and Development) - ideally, I would like to extract the common parts and just keep the ones that are specific to AdHoc vs. Development.

For some reason, when I run the build command locally, TS keeps complaining that @expo/eas-json is not installed, even though I ran yarn in the project root. Any idea why this would happen?

Test Plan

None as of now

At the current state, this PR is a proof-of-concept, untested, and is just in its inception phase - I'm looking for your feedback on whether this is a good direction/approach to take and any API design recommendations.

Thank you!

[brentvatne]

cc @quinlanj - i believe you explored development provisioning profiles before and there wasn't a clear way to make this work

[quinlanj]

@brentvatne I looked into Developer profiles a while back, but it was for free developer accounts, which we discovered doesn’t work with the regular Apple API’s.

@fobos531 Thanks for this initial PR. Could you confirm my understanding of your usecase:


1. You want to sign your app with a Developer profile. The only reason for this is because of an Apple restriction for the Tap To Pay feature.
2. You want a similar workflow to our internal distribution, but use the development profile instead of the adhoc profile
3. You want to add your test device UDIDs to the Development profile and build your app with eas-cli
4. You want to distribute your built app to your test device with the installation link we provide on the website.

If this is correct, would you be able to test building a Development profile in your local eas-cli? You can build it all under the ‘internal distribution’ codepath, but change the parameters to the Apple API to make the Development profile instead. Ideally you would be able to distribute it with the installation link we provide in the website. I’ve never tried to do this, so it would be super helpful to know if all the functionality is preserved 😮

[quinlanj]

@fobos531 also to answer your question about @expo/eas-json - try running yarn build at the root level of the repo, this should link the eas-json package

[fobos531]

@brentvatne I looked into Developer profiles a while back, but it was for free developer accounts, which we discovered doesn’t work with the regular Apple API’s.

@fobos531 Thanks for this initial PR. Could you confirm my understanding of your usecase:


1. You want to sign your app with a Developer profile. The only reason for this is because of an Apple restriction for the Tap To Pay feature.
2. You want a similar workflow to our internal distribution, but use the development profile instead of the adhoc profile
3. You want to add your test device UDIDs to the Development profile and build your app with eas-cli
4. You want to distribute your built app to your test device with the installation link we provide on the website.

If this is correct, would you be able to test building a Development profile in your local eas-cli? You can build it all under the ‘internal distribution’ codepath, but change the parameters to the Apple API to make the Development profile instead. Ideally you would be able to distribute it with the installation link we provide in the website. I’ve never tried to do this, so it would be super helpful to know if all the functionality is preserved 😮

Hey @quinlanj !

Yes, that is exactly the workflow I am looking for. You couldn't have said it better.

I tried testing building a development profile, but it seems that for me to do that, I first have to have a Development certificate. Creating it on the portal is easy enough, but the intended workflow of eas-cli prevents me from selecting that certificate, since it looks like the GraphQL query to Expo's API is only configured to get distribution certificates. Does Expo's API support getting the development certificates as well? If yes, it seems like that query is not present in the GraphQL generated types - could you assist me on how to do this?

[quinlanj]

@fobos531 we'll need to change the servers to support development certificates properly. As a hacky workaround to test the functionality for now, can you try to upload it as an adhoc distribution certificate via the graphql API? afaict, distribution and development certs are of the same format, so it's worth a shot.

If this doesnt work can you link the problematic line of code or send a screenshot of the cli workflow that is blocking you?