-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --non-interactive and --force support when --id is not passed to eas init command #1983
base: main
Are you sure you want to change the base?
Conversation
…o eas init command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Thank you very much for contributing 👏 ! Sorry that you waited so long for the response 🙏.
It generally looks good 🚀! I just tested it locally and it seems like it won't work in its current form because
eas-cli/packages/eas-cli/src/commands/project/init.ts
Lines 35 to 43 in 04049a8
force: Flags.boolean({ | |
description: 'Whether to overwrite any existing project ID', | |
dependsOn: ['id'], | |
}), | |
// this is the same as EASNonInteractiveFlag but with the dependsOn | |
'non-interactive': Flags.boolean({ | |
description: 'Run the command in non-interactive mode.', | |
dependsOn: ['id'], | |
}), |
the
force
and non-interactive
flags depend on the id
flag. So currently you won't be able to use force
and non-interactive
without the id
flag specified.
Are you still interested in working on this PR? If so, I can provide you with some guidance:
- https://github.com/expo/eas-cli/blob/main/CONTRIBUTING.md - Here are some instructions regarding how you can run EAS CLI locally to test it, it will be easier for you if you can actually test it 😄
- The next thing to do is to delete this flag dependency. I hope that after this is done everything will work fine! 🚀
Let me know if you have any more questions or need some help!
Thanks again 🙏!
Thank you for your feedback! :) I have been on holiday but still very interested in working on this. I will hopefully have time to look at this again at some stage this week. |
Bumps [undici](https://github.com/nodejs/undici) from 5.19.1 to 5.26.3. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.19.1...v5.26.3) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…26.3 Bump undici from 5.19.1 to 5.26.3
…undici-5.26.3 Revert "Bump undici from 5.19.1 to 5.26.3"
@szdziedzic , do you have some time to have another look at this? The flag dependency has been removed. |
Why
We have recently updated to version
3.17.0
ofeas-cli
(from1.2.0
). Theeas init
command previously supported running without prompts to either:app.json
file asextra.eas.projectId
.The version
3.17.0
eas init
command does support--non-interactive
and--force
but not for the two use cases above.How
I added support the --force and --non-interactive to the following two prompts (ids and names are just examples):
Test Plan
Untested, open to feedback before continuing with implementation.