Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french translation #286

Merged
merged 9 commits into from May 11, 2024
Merged

Add french translation #286

merged 9 commits into from May 11, 2024

Conversation

Charpy
Copy link
Contributor

@Charpy Charpy commented May 9, 2024

Hi,
Here is my french translation for both the client and the app.

Charpy added 7 commits May 7, 2024 01:36
French translation, WIP.
Traduction française en cours.
Working on the french translation. Work in progress.

Traduction française en cours.
End of french translation
Fin de la traduction française
French translation of english.json
Traduction française de english.json
Restauration du fichier english.json
Cleaning small typo
Small spell check
@exelix11
Copy link
Owner

exelix11 commented May 10, 2024

There are two new lines in

"NotInstalled" : "SysDVR is not installed on your console",
"NotInsalledSecondLine" : "The file /atmosphere/contents/00FF0000A53BB665/exefs.nsp was not found on your SD card, this means you did not extract the SysDVR zip correctly. Fix the issue then reboot the console."
could you add them ?

@exelix11
Copy link
Owner

Also for the config app to use your translation you will have to change this line

https://github.com/exelix11/SysDVR/blob/master/SysDVRConfig/source/translaton.cpp#L30

to

{ "SetLanguage_FR", ASSET("strings/french.json")},

Did you test the translation to make sure all special characters with accents render correctly ? If there are missing characters we'll have to find a font that supports them.

Adding two new lines for 2 kind of user error messages.
Add french strings path
@exelix11 exelix11 merged commit 128c462 into exelix11:master May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants