Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start Stop offset #785

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Start Stop offset #785

wants to merge 16 commits into from

Conversation

luzip665
Copy link
Contributor

This PR is a replacement for #753

@luzip665 luzip665 mentioned this pull request Dec 23, 2021
Closed
@luzip665
Copy link
Contributor Author

@virtuald
I would like to implement unit tests for this feature. But, I have no idea, how.
I think I can write a test for the tags, so that it's possible to check whether it's possible to use negative values for the start.

But how can the player be tested?

@virtuald
Copy link
Member

I'm not really sure how to write tests that use gstreamer, unfortunately. It's fine if we don't have tests, just would be nice if the functionality could be somehow tested.

@virtuald
Copy link
Member

Also, I can't try this at the moment, so I'll review in a few days when I can.

virtuald
virtuald requested changes Jan 2, 2022
View reviewed changes
xl/player/player.py Outdated Show resolved Hide resolved
xl/player/player.py Outdated Show resolved Hide resolved
xl/player/player.py Outdated Show resolved Hide resolved
xl/player/player.py Outdated Show resolved Hide resolved
xl/player/player.py Outdated Show resolved Hide resolved
xl/player/player.py Outdated Show resolved Hide resolved
@luzip665 luzip665 marked this pull request as draft January 4, 2022 14:43
@luzip665
Copy link
Contributor Author

luzip665 commented Jan 4, 2022

I reworked a little, but it still not works with gapless and fader...

@luzip665 luzip665 marked this pull request as ready for review January 7, 2022 18:23
@luzip665
Copy link
Contributor Author

luzip665 commented Jan 7, 2022

Finally I end up in moving everything to AudioStream.
Starting there it works with gapless.

@virtuald Can you have a lookg for the AudioStream class?

Next I'm working on the properties window and rebasing.

@luzip665 luzip665 requested a review from virtuald January 8, 2022 14:14
@virtuald
Copy link
Member

virtuald commented Jan 8, 2022

AudioStream seems like a better place for it (ha, I forgot it even existed!), but I don't have time at the moment to properly review. Will try to do so in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virtuald virtuald Awaiting requested review from virtuald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luzip665 @virtuald