Support for MusicBrainz ID tags on MP3 and MP4 files #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://picard.musicbrainz.org/docs/mappings/ The mapping is from the "Vorbis" entry to the "ID3" or "iTunes MP4" entry. Fixes: exaile#692
For most of the tags with subtags, e.g. APIC:... or WOAR:..., we remove those subtags. We can't do this for TXXX:..., which are all custom tags. This change allows the Track Properties dialog to show the musicbrainz_* tags.
sjohannes
force-pushed
the
musicbrainz
branch
from
74a0959
to
c9aa4f7
Compare
|
Never mind, keeping this as a draft for now. The tags can't be saved yet: ERROR : Unknown exception: Could not write tags to file
Traceback (most recent call last):
File "/exaile/xl/trax/track.py", line 362, in write_tags
f.write_tags(self.__tags)
File "/exaile/xl/metadata/_base.py", line 286, in write_tags
self._set_tag(raw, rtag, value)
File "/exaile/xl/metadata/_id3.py", line 155, in _set_tag
frames = [id3.Frames[tag](encoding=3, text=data)]
KeyError: 'TXXX:MusicBrainz Album Id' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a fix to the _id3 module for a bug causing TXXX (custom) tags to be ignored.
Also adds isrc tag for MP4.
Fixes: #692