Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MusicBrainz tag mappings #692

Open
sjohannes opened this issue Mar 7, 2020 · 0 comments · May be fixed by #731
Open

Add MusicBrainz tag mappings #692

sjohannes opened this issue Mar 7, 2020 · 0 comments · May be fixed by #731
Assignees
@sjohannes
Labels
Blocker Component: core Type: enhancement
Milestone
Exaile 4.2.0

Comments

@sjohannes
Copy link
Member

sjohannes commented Mar 7, 2020 •
edited

The cover cache tries to use musicbrainz_albumid when it exists, but that's the Vorbis tag name. MP3 and MP4 use different ones: https://picard.musicbrainz.org/docs/mappings/

@genodeftest's new CD plugin #652 (comment) also needs this for some of the other tags.

I have an old prototype at master...sjohannes:musicbrainz but:

  1. musicbrainz_album should be musicbrainz_albumid.
  2. There's a difference between MUSICBRAINZ_TRACKID (MusicBrainz Recording Id) and MUSICBRAINZ_RELEASETRACKID (MusicBrainz Track Id). Which one maps better to our concept of a "track"? I'm pretty sure it's MUSICBRAINZ_RELEASETRACKID but will have to compare with what Picard outputs.
  3. Need mapping for isrc (used by the new CD plugin).
  4. Anything else needed for the CD plugin?
@sjohannes sjohannes added this to the Exaile 4.1 milestone Mar 7, 2020
@sjohannes sjohannes self-assigned this Mar 7, 2020
sjohannes added a commit to sjohannes/exaile that referenced this issue Nov 14, 2020
@sjohannes
metadata/{_id3,mp4}: Add tag mapping entries for MusicBrainz IDs
6058141 
Based on https://picard.musicbrainz.org/docs/mappings/

The mapping is from the "Vorbis" entry to the "ID3" or "iTunes MP4" entry.

Fixes: exaile#692
@sjohannes sjohannes linked a pull request Nov 14, 2020 that will close this issue
Draft
sjohannes added a commit to sjohannes/exaile that referenced this issue Nov 14, 2020
@sjohannes
metadata/{_id3,mp4}: Add tag mapping entries for MusicBrainz IDs
281d773 
Based on https://picard.musicbrainz.org/docs/mappings/

The mapping is from the "Vorbis" entry to the "ID3" or "iTunes MP4" entry.

Fixes: exaile#692
@sjohannes sjohannes modified the milestones: Exaile 4.1.0, Exaile 4.1.1 Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohannes sjohannes

Labels
Blocker Component: core Type: enhancement
Projects
None yet
Milestone
Exaile 4.2.0
Development

Successfully merging a pull request may close this issue.

Support for MusicBrainz ID tags on MP3 and MP4 files sjohannes/exaile
1 participant
@sjohannes