AMR: explicit timestepping for convection diffusion module #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardschu
commented
Jan 4, 2024
|
|
||
| mark_cells_coarsening_and_refinement(*grid->triangulation, | ||
| bdf_time_integrator->get_solution_np()); | ||
| // Mark cells for coarsening and refinement based on the most recent solution. |
There was a problem hiding this comment.
introducing TimeIntBase::get_solution_np() would lead to:
mark_cells_for_coarsening_and_refinement(*grid->triangulation, time_integrator->get_solution_np());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables explicit time integration in the convection diffusion module together with adaptive mesh refinement and adds a little test case.
The test uses a static mapping already (similar to the test with the implicit time stepping). The error is a bit lower compared to the implicit test, which computes the same scenario.
I did not add
get_solution_np()toTimeIntBase, which requires some dynamic casts of thetime_integratorin the driver.