-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MappingDoFVector (ALE) for ElementType::Simplex #634
base: master
Are you sure you want to change the base?
Conversation
The first commit shows which places we need to extend / re-implement for simplex by introducing if-else-branches depending on the |
@kronbichler as discussed in person, the current implementation of |
b6e3210
to
ef85280
Compare
I had a close look at the code now. I think the new approach looks good. For the simplices, we do not have the equivalent of |
…mber variable of MappingDoFVector
e544a73
to
923958b
Compare
@kronbichler thanks for your review. We need some more refactoring in order to integrate Simplex elements easily without having to touch several classes (see 923958b and 7fbcbe8). |
"DegreeMin": "2", | ||
"DegreeMax": "2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was not actually intended and might cause the test to fail.
To enable ALE methods for
ElementType::Simplex
, we need to extendMappingDoFVector
:fill_grid_coordinates_vector()
(in order to translate aMapping
into aDoFVector
)initialize_mapping_from_dof_vector()
(in order to translate aDoFVector
into aMapping
)MappingTools
:initialize_coarse_mappings_from_mapping_dof_vector()
to construct coarse mappings of typeMappingDoFVector
for use in h-multigrid methodsElementType::Simplex
(@peterrum)?@dominiktassilostill FYI