Add cylinder flag fsi test #571
Conversation
|
... this is to remind me that I should check if the test was actually picked up |
| @@ -148,10 +148,9 @@ SolverFluid<dim, Number>::setup(std::shared_ptr<FluidFSI::ApplicationBase<dim, N | |||
| // initialize time_integrator | |||
| helpers_ale = std::make_shared<HelpersALE<Number>>(); | |||
|
|
|||
| bool print_solver_info = is_test ? false : time_integrator->print_solver_info(); | |||
There was a problem hiding this comment.
I am not sure if this works as intended because time_integrator->print_solver_info() might be true/false depending on the time step (say solver info is going to be printed every 10th time step). However, the variable print_solver_info will then take the same value throughout a whole simulation, doesn't it?
There was a problem hiding this comment.
I moved it inside now, this is work in progress :)
|
halleluja |
| @@ -30,3 +30,5 @@ TARGETNAME(TARGET_NAME ${CMAKE_CURRENT_SOURCE_DIR}) | |||
| PROJECT(${TARGET_NAME}) | |||
|
|
|||
| EXADG_PICKUP_EXE(solver.cpp ${TARGET_NAME} solver) | |||
|
|
|||
| ADD_SUBDIRECTORY(tests) | |||
There was a problem hiding this comment.
Can you please insert a line break at the end of the file.
There was a problem hiding this comment.
sure, is something like this the reason?
| @@ -178,19 +200,20 @@ class Application : public FluidFSI::ApplicationBase<dim, Number> | |||
|
|
|||
| // PHYSICAL QUANTITIES | |||
| param.start_time = 0.0; | |||
| param.end_time = END_TIME; | |||
| param.end_time = END_TIME * end_time_factor; | |||
There was a problem hiding this comment.
Should we really introduce a factor for the time via the input file, but keep the END_TIME as a separate variable? I would prefer to specify the actual final time, because setting information in two places is usually confusing.
There was a problem hiding this comment.
hmmm ... I did not want to throw away the heuristic
double const END_TIME = 4.0 * L / U_MEAN;
that is the only reason I kept this. If I were to write this application from scratch, I would give the end_time to the user to provide in the .json file.
. add a 2D test for the FSI application
cylinder_with_flag. introduce a scaling factor for the
end_timeused in the application to shorten the test duration. compute reference values of velocity, pressure and displacement to compare in the generated output ("absolute error" taking zero as "exact solution")
. suppress iteration count and wall time output by mesh motion
ale_mapping->updatecalled during ALE update in fluid solver