[WIP] Add google test for unittests #360
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce new template parameter `coefficient_t` to `VariableCoefficients` (and to the related `VariableCoefficientsCell`) in order to hold arbitrary coefficient types (like tensors of different ranks). (Closes exadg#289) - Extend the interface to get the `quad_index` alongside a `MatrixFree` object to correctly obtain the number of quadrature points that are needed. Previous calculation of the number of q points falsely relied on the polynomial degree. (Closes exadg#128) Also: - Refactor two separate methods `reinit` and `fill` out of the `initialize` method. - Remove the propagated n_q_points_1d variable in the structure module, which is not needed anymore. - Pass in the quad_index into the viscous kernel initializer as it is needed to get the correct quadrature formula.
Add Googletest dependency for unit test development (Part of exadg#359). - Add a unit test suite for VariableCoefficients - Rewrite the existing ElementwiseGMRES test with Googletest (keep the old one as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I'd like to introduce Googletest for writing unit tests in ExaDG.
The discussion on whether Googletest is desired is planned to take place in #359. This PR should be an example of what it may look like if we do.
To make the case for Googletest, I have written two test suites with it.
An exact transfer of the test cases for
Elementwise::SolverGMRESwhich we already had. Aside from reducing the number of lines, especially duplicated lines, I found that the tests would also run considerably faster with the new framework. The time required for this test suite dropped from about 17 seconds to no more than 10 seconds on my local machine.A typed-test suite for the newly implemented generalized
VariableCoefficientsclass (Generalize variable coefficients to arbitrary types #353). A typed-test in this context means that multiple tests are created automatically for templated types. In this case, I testedVariableCoefficientswith three different coefficient types.Part of #359
Follows #353