implement slip BC for IncNS #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterrum @kronbichler could you review this PR? |
peterrum
reviewed
Mar 6, 2023
Comment on lines
210
to
219
| u_p = u_m - 2. * (u_m * normal_m) * normal_m; | ||
|
|
||
| if(type_dirichlet_bc == TypeDirichletBCs::Mirror) | ||
| { | ||
| u_p = u_m - 2. * (u_m * normal_m) * normal_m; | ||
| } | ||
| else if(type_dirichlet_bc == TypeDirichletBCs::Direct) | ||
| { | ||
| u_p = u_m - (u_m * normal_m) * normal_m; | ||
| } |
There was a problem hiding this comment.
Is this right? Why is the same equation written twice!?
There was a problem hiding this comment.
line 210 needs to be removed. I introduced the if-else-branch but did not remove the line that was there before.
kronbichler
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #292